fix(create): Add messaging when done #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After running the
createcommand there's no messaging indicating that the library was successfully created. In fact, the last thing rendered to the screen is thecpcommand that copies over the config files. I actually thought the command was broken and thecphad failed.Solution
Replaced the
cpcommand with friendly text that says "Copying repo config files." and more importantly when the creation is completed it says "[repoName] successfully created" if the library name was specified (new lib) or "Repo successfully updated" for an existing repo.Also added an update to the
releaseworkflow to run the unit tests one more time as a double check to make sure we're not releasing broken code that's merged intomaster.