feat!: Add linting for react-testing-library #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmvp
changed the title
benmvp
force-pushed
the
react-testing-library-linting
branch
from
559f561
to
15b420a
Compare
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was no linting for
@testing-library/reactyet thepackage.jsonwas already installingeslint-plugin-testing-library.Solution
Added
'plugin:testing-library/react'as one of the plugins theeslint.config.jsextends from to receive the recommended react ESLint rules.Fixes #81
BREAKING CHANGE: This is now failing for new lint errors so it's technically a breaking change, although it should be super-duper minor.