Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sub-nanosecond precision on Cargo benchmarks #244

Closed
ktrz opened this issue May 19, 2024 · 1 comment · Fixed by #246
Closed

Support sub-nanosecond precision on Cargo benchmarks #244

ktrz opened this issue May 19, 2024 · 1 comment · Fixed by #246
Labels
bug Something isn't working

Comments

@ktrz
Copy link
Member

ktrz commented May 19, 2024

In rust-lang/rust#124774, Rust changed the output of benchmarks to contain sub-nanosecond precision. This was first published in nightly-2024-05-11 which started breaking CI that used github-action-benchmark since it couldn't find any benchmarks in an output file.

#243 (comment)
@ktrz ktrz added the bug Something isn't working label May 19, 2024
@ktrz ktrz linked a pull request May 19, 2024 that will close this issue
fix: Support sub-nanosecond precision on Cargo benchmarks #243
Closed
@ktrz ktrz mentioned this issue May 19, 2024
Merged
@ktrz ktrz closed this as completed in #246 May 19, 2024
@ktrz
Copy link
Member Author

ktrz commented May 19, 2024

released in v1.20.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ktrz