Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xamarin fails to publish due to Nordic characters in Method names #497

Closed
takthetank opened this issue Sep 5, 2023 · 2 comments · Fixed by #522
Closed

Xamarin fails to publish due to Nordic characters in Method names #497

takthetank opened this issue Sep 5, 2023 · 2 comments · Fixed by #522
Labels

Comments

@takthetank
Copy link

Version Information

Software Version(s)
Bogus NuGet Package 34.0.2
.NET Core? Xamarin with .Net Standard 2.1
.NET Full Framework? -
Windows OS? 10
Linux OS? -
Visual Studio? 17.7.3 (2022)

What locale are you using with Bogus?

Default, EN.

What is the expected behavior?

When compiling a Xamarin.Forms bundle for Android, it should compile successfully.

What is the actual behavior?

Compilation fails due to weird Scandinavian characters in some methods.
image

Please provide a stack trace.

(Does not apply)

Any possible solutions?

Rename these methods to include plain latin characters.

How do you reproduce the issue?

Use the library in a Xamarin.Forms Android project and create a bundle for publishing.

Do you have a unit test that can demonstrate the bug?

(Does not apply)

Can you identify the location in Bogus' source code where the problem exists?

Bogus.Extensions.Finland.ExtensionsForFinland.Henkilötunnus()
Bogus.Extensions.Norway.ExtensionsForNorway.Fødselsnummer()

If the bug is confirmed, would you be willing to submit a PR?

Yes

@bchavez
Copy link
Owner

bchavez commented Sep 14, 2023

Hm. Wow. Pretty interesting bug report. Thank you for the report. Looks like we'll have to work on removing those glyphs in method names.

@bchavez bchavez added the bug label Sep 14, 2023
@takthetank takthetank changed the title Xamarin fails to publish doe to Nordic characters in Method names Xamarin fails to publish due to Nordic characters in Method names Sep 14, 2023
bchavez added a commit that referenced this issue Dec 26, 2023
Fix up unit tests
Add release HISTORY.md changelog.
bchavez added a commit that referenced this issue Dec 26, 2023
Fix up unit tests
Add release HISTORY.md changelog.
bchavez added a commit that referenced this issue Dec 26, 2023
Fix up unit tests
Add release HISTORY.md changelog.
@bchavez
Copy link
Owner

bchavez commented Dec 26, 2023

The issue should be fixed in Bogus v35.2.0:

Thanks again for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants