Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename transformed (Update for Measure terminology) #441

Open
wants to merge 53 commits into
base: main
Choose a base branch
from

Conversation

Micki-D
Copy link
Collaborator

@Micki-D Micki-D commented Jun 3, 2024

Updates the original PR #409 with the new measure terminology.

AG and others added 30 commits June 30, 2023 12:49
Co-Authored-By: Cornelius-G <Cornelius-G@users.noreply.github.com>
@Micki-D
Copy link
Collaborator Author

Micki-D commented Jun 3, 2024

So the failing tests are due to errors in the generation of viable MCMC chains.
But I am unsure if this is due to issues with the Measure terminology or due to issues in the original PR #409.
Were there any known issues with the transformed MCMC algorithms @Cornelius-G ? Thanks!

@Micki-D
Copy link
Collaborator Author

Micki-D commented Jun 3, 2024

Also, @oschulz is there a convention for when to use 'X_density' or 'X_measure' or 'm' as variable names?
It's unclear to me from the existing code.
Thanks!

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 9.83146% with 642 lines in your changes missing coverage. Please review.

Project coverage is 42.60%. Comparing base (67ac2bf) to head (427481f).
Report is 2 commits behind head on main.

Current head 427481f differs from pull request most recent head 189c285

Please upload reports for the commit 189c285 to get more accurate results.

Files Patch % Lines
src/samplers/transformed_mcmc/mcmc_iterate.jl 0.00% 126 Missing ⚠️
src/samplers/transformed_mcmc/chain_pool_init.jl 0.00% 111 Missing ⚠️
src/samplers/transformed_mcmc/mcmc_convergence.jl 0.00% 56 Missing ⚠️
src/samplers/transformed_mcmc/mcmc_stats.jl 0.00% 56 Missing ⚠️
...sformed_mcmc/mcmc_tuning/mcmc_proposalcov_tuner.jl 0.00% 54 Missing ⚠️
src/samplers/transformed_mcmc/proposaldist.jl 0.00% 43 Missing ⚠️
...rc/samplers/transformed_mcmc/multi_cycle_burnin.jl 0.00% 37 Missing ⚠️
src/samplers/transformed_mcmc/mcmc_algorithm.jl 0.00% 30 Missing ⚠️
...ers/transformed_mcmc/mcmc_tuning/mcmc_ram_tuner.jl 0.00% 30 Missing ⚠️
src/samplers/transformed_mcmc/mcmc_sample.jl 0.00% 29 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   47.26%   42.60%   -4.67%     
==========================================
  Files         111      127      +16     
  Lines        5385     6068     +683     
==========================================
+ Hits         2545     2585      +40     
- Misses       2840     3483     +643     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants