Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More compilation fixes #3139

Merged
merged 5 commits into from
Jan 2, 2024
Merged

More compilation fixes #3139

merged 5 commits into from
Jan 2, 2024

Conversation

hadess
Copy link
Contributor

@hadess hadess commented Dec 16, 2023

Follow-up from #3096

@hadess hadess force-pushed the wip/hadess/fix-compilation-problems branch 2 times, most recently from fd08c0c to 51058b0 Compare December 16, 2023 10:39
@hadess
Copy link
Contributor Author

hadess commented Dec 19, 2023

Happy to split this up in smaller merge requests if it helps landing them.

@lanewei120
Copy link
Collaborator

@hadess

thanks very much for doing this,
could you merge thoses commit into one?

too much commits will cause the history overly lengthy

@hadess hadess mentioned this pull request Dec 21, 2023
Closed
2 tasks
@hadess hadess force-pushed the wip/hadess/fix-compilation-problems branch from eade717 to 6b7ec30 Compare December 21, 2023 09:12
@hadess
Copy link
Contributor Author

hadess commented Dec 21, 2023

thanks very much for doing this,
could you merge thoses commit into one?

Done. It's now 4 separate commits. I wanted to make sure that the biggest ones that didn't just require a new include get their own commits to explain.

@hadess
libslic3r: Fix missing includes
c6336c9 
Fix a lot of "undeclared" errors during compilation on top of the
current GNOME 45 Flatpak SDK.
@hadess
libslic3r: Fix Slic3r::format declaration
9b3bc42
@hadess
slic3r: Fix missing includes
37b4496 
Fix a lot of "undeclared" errors during compilation on top of the
current GNOME 45 Flatpak SDK.
@hadess
Fix ModelObject declaration
6b94ceb 
Forward declare ModelObject in bbs_3mf.hpp so this header can be
included in ModelObject.hpp where the class is actually defined,
the same way bbs_3mf.hpp also forward declares "class Model" and
others.

[274/471] Building CXX object src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/Printer/PrinterFileSystem.cpp.o
FAILED: src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/Printer/PrinterFileSystem.cpp.o
/run/ccache/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CHRONO_NO_LIB -DBOOST_DATE_TIME_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_IOSTREAMS_NO_LIB -DBOOST_LOCALE_NO_LIB -DBOOST_LOG_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DCURL_STATICLIB -DGLEW_STATIC -DLIBNEST2D_GEOMETRIES_libslic3r -DLIBNEST2D_OPTIMIZER_nlopt -DLIBNEST2D_STATIC -DLIBNEST2D_THREADING_tbb -DOPENSSL_CERT_OVERRIDE -DOPENVDB_OPENEXR_STATICLIB -DOPENVDB_STATICLIB -DSLIC3R_CURRENTLY_COMPILING_GUI_MODULE -DSLIC3R_GUI -DTBB_USE_CAPTURED_EXCEPTION=0 -DUNICODE -DUSE_TBB -DWXINTL_NO_GETTEXT_MACRO -D_FILE_OFFSET_BITS=64 -D_UNICODE -D__WXGTK3__ -D__WXGTK__ -DwxDEBUG_LEVEL=0 -DwxNO_UNSAFE_WXSTRING_CONV -DwxUSE_UNICODE -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/run/build/BambuStudio/src -I/run/build/BambuStudio/build/src/platform -I/run/build/BambuStudio/src/hidapi/include -I/run/build/BambuStudio/src/slic3r/Utils -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/run/build/BambuStudio/deps/build/destdir/usr/local/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/atk-1.0 -I/usr/include/blkid -I/usr/include/libmount -I/usr/include/sysprof-6 -I/run/build/BambuStudio/deps/build/destdir/usr/local/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/gio-unix-2.0 -I/usr/include/fribidi -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/gstreamer-1.0 -I/run/build/BambuStudio/build/src/libslic3r -I/run/build/BambuStudio/deps/build/destdir/usr/local/include/opencascade -I/run/build/BambuStudio/src/libnest2d/include -I/run/build/BambuStudio/src/miniz -I/run/build/BambuStudio/src/glu-libtess/include -I/run/build/BambuStudio/src/clipper2/Clipper2Lib/include -I/run/build/BambuStudio/src/minilzo -isystem /run/build/BambuStudio/src/eigen -isystem /run/build/BambuStudio/src/libigl -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/lib/wx/include/gtk3-unicode-static-3.2 -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/include/wx-3.2 -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/include -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78 -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/include/OpenEXR -std=gnu++20 -fext-numeric-literals -Wall -Wno-reorder -pthread -O3 -DNDEBUG -std=gnu++17 -fPIC -fsigned-char -Werror=return-type -Wno-ignored-attributes -Wno-unknown-pragmas -DOPENVDB_ABI_VERSION_NUMBER=8 -MD -MT src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/Printer/PrinterFileSystem.cpp.o -MF src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/Printer/PrinterFileSystem.cpp.o.d -o src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/Printer/PrinterFileSystem.cpp.o -c /run/build/BambuStudio/src/slic3r/GUI/Printer/PrinterFileSystem.cpp
In file included from /run/build/BambuStudio/src/slic3r/GUI/Printer/PrinterFileSystem.cpp:3:
/run/build/BambuStudio/src/libslic3r/Format/bbs_3mf.hpp:264:13: error: variable or field ‘save_object_mesh’ declared void
  264 | extern void save_object_mesh(ModelObject& object);
      |             ^~~~~~~~~~~~~~~~
/run/build/BambuStudio/src/libslic3r/Format/bbs_3mf.hpp:264:30: error: ‘ModelObject’ was not declared in this scope
  264 | extern void save_object_mesh(ModelObject& object);
      |                              ^~~~~~~~~~~
/run/build/BambuStudio/src/libslic3r/Format/bbs_3mf.hpp:264:43: error: ‘object’ was not declared in this scope; did you mean ‘nlohmann::detail::value_t::object’?
  264 | extern void save_object_mesh(ModelObject& object);
      |                                           ^~~~~~

Closes: bambulab#3141
@hadess
Fix system() declaration
9ace192 
[380/471] Building CXX object src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/HttpServer.cpp.o
FAILED: src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/HttpServer.cpp.o
/run/ccache/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CHRONO_NO_LIB -DBOOST_DATE_TIME_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_IOSTREAMS_NO_LIB -DBOOST_LOCALE_NO_LIB -DBOOST_LOG_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DCURL_STATICLIB -DGLEW_STATIC -DLIBNEST2D_GEOMETRIES_libslic3r -DLIBNEST2D_OPTIMIZER_nlopt -DLIBNEST2D_STATIC -DLIBNEST2D_THREADING_tbb -DOPENSSL_CERT_OVERRIDE -DOPENVDB_OPENEXR_STATICLIB -DOPENVDB_STATICLIB -DSLIC3R_CURRENTLY_COMPILING_GUI_MODULE -DSLIC3R_GUI -DTBB_USE_CAPTURED_EXCEPTION=0 -DUNICODE -DUSE_TBB -DWXINTL_NO_GETTEXT_MACRO -D_FILE_OFFSET_BITS=64 -D_UNICODE -D__WXGTK3__ -D__WXGTK__ -DwxDEBUG_LEVEL=0 -DwxNO_UNSAFE_WXSTRING_CONV -DwxUSE_UNICODE -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/run/build/BambuStudio/src -I/run/build/BambuStudio/build/src/platform -I/run/build/BambuStudio/src/hidapi/include -I/run/build/BambuStudio/src/slic3r/Utils -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/run/build/BambuStudio/deps/build/destdir/usr/local/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/atk-1.0 -I/usr/include/blkid -I/usr/include/libmount -I/usr/include/sysprof-6 -I/run/build/BambuStudio/deps/build/destdir/usr/local/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/gio-unix-2.0 -I/usr/include/fribidi -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/gstreamer-1.0 -I/run/build/BambuStudio/build/src/libslic3r -I/run/build/BambuStudio/deps/build/destdir/usr/local/include/opencascade -I/run/build/BambuStudio/src/libnest2d/include -I/run/build/BambuStudio/src/miniz -I/run/build/BambuStudio/src/glu-libtess/include -I/run/build/BambuStudio/src/clipper2/Clipper2Lib/include -I/run/build/BambuStudio/src/minilzo -isystem /run/build/BambuStudio/src/eigen -isystem /run/build/BambuStudio/src/libigl -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/lib/wx/include/gtk3-unicode-static-3.2 -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/include/wx-3.2 -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/include -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78 -isystem /run/build/BambuStudio/deps/build/destdir/usr/local/include/OpenEXR -std=gnu++20 -fext-numeric-literals -Wall -Wno-reorder -pthread -O3 -DNDEBUG -std=gnu++17 -fPIC -fsigned-char -Werror=return-type -Wno-ignored-attributes -Wno-unknown-pragmas -DOPENVDB_ABI_VERSION_NUMBER=8 -MD -MT src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/HttpServer.cpp.o -MF src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/HttpServer.cpp.o.d -o src/slic3r/CMakeFiles/libslic3r_gui.dir/GUI/HttpServer.cpp.o -c /run/build/BambuStudio/src/slic3r/GUI/HttpServer.cpp
In file included from /run/build/BambuStudio/deps/build/destdir/usr/local/include/wx-3.2/wx/string.h:36,
                 from /run/build/BambuStudio/src/slic3r/GUI/ImGuiWrapper.hpp:9,
                 from /run/build/BambuStudio/src/slic3r/GUI/GUI_App.hpp:6,
                 from /run/build/BambuStudio/src/slic3r/GUI/HttpServer.cpp:4:
/run/build/BambuStudio/deps/build/destdir/usr/local/include/wx-3.2/wx/wxcrt.h: In function ‘int wxSystem(const wxString&)’:
/run/build/BambuStudio/deps/build/destdir/usr/local/include/wx-3.2/wx/wxcrt.h:1037:51: error: reference to ‘system’ is ambiguous
 1037 | inline int wxSystem(const wxString& str) { return wxCRT_SystemA(str.mb_str()); }
      |                                                   ^~~~~~~~~~~~~
In file included from /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78/boost/system/detail/error_code.hpp:13,
                 from /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78/boost/system/error_code.hpp:13,
                 from /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78/boost/beast/core/error.hpp:14,
                 from /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78/boost/beast/core/detail/bind_handler.hpp:13,
                 from /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78/boost/beast/core/bind_handler.hpp:14,
                 from /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78/boost/beast/core/async_base.hpp:14,
                 from /run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78/boost/beast/core.hpp:15,
                 from /run/build/BambuStudio/src/slic3r/GUI/HttpServer.hpp:8,
                 from /run/build/BambuStudio/src/slic3r/GUI/HttpServer.cpp:2:
/run/build/BambuStudio/deps/build/destdir/usr/local/include/boost-1_78/boost/system/is_error_code_enum.hpp:16:11: note: candidates are: ‘namespace boost::system { }’
   16 | namespace system
      |           ^~~~~~
In file included from /usr/include/c++/13.2.0/cstdlib:79,
                 from /run/build/BambuStudio/src/slic3r/GUI/HttpServer.cpp:1:
/usr/include/stdlib.h:923:12: note:                 ‘int system(const char*)’
  923 | extern int system (const char *__command) __wur;
      |            ^~~~~~
@hadess hadess force-pushed the wip/hadess/fix-compilation-problems branch from 6b7ec30 to 9ace192 Compare December 21, 2023 09:45
@hadess hadess mentioned this pull request Dec 29, 2023
Closed
@lanewei120 lanewei120 merged commit f96b6cd into bambulab:master Jan 2, 2024
2 checks passed
@hadess hadess deleted the wip/hadess/fix-compilation-problems branch January 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanewei120 lanewei120 Awaiting requested review from lanewei120

@bambu123 bambu123 Awaiting requested review from bambu123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadess @lanewei120