diff --git a/Source/Charts/Data/Implementations/Standard/ChartDataSet.swift b/Source/Charts/Data/Implementations/Standard/ChartDataSet.swift index 1a9d235395..9922878da8 100644 --- a/Source/Charts/Data/Implementations/Standard/ChartDataSet.swift +++ b/Source/Charts/Data/Implementations/Standard/ChartDataSet.swift @@ -31,11 +31,9 @@ open class ChartDataSet: ChartBaseDataSet super.init() } - public override init(label: String?) + public override convenience init(label: String?) { - entries = [] - - super.init(label: label) + self.init(entries: nil, label: label) } @objc public init(entries: [ChartDataEntry]?, label: String?) diff --git a/Tests/Charts/BarChartTests.swift b/Tests/Charts/BarChartTests.swift index 6f323223e2..c27ef6f22e 100644 --- a/Tests/Charts/BarChartTests.swift +++ b/Tests/Charts/BarChartTests.swift @@ -109,6 +109,16 @@ class BarChartTests: FBSnapshotTestCase let dataSet = setupDefaultDataSet(chartDataEntries: dataEntries) let chart = setupDefaultChart(dataSets: [dataSet]) ChartsSnapshotVerifyView(chart, identifier: Snapshot.identifier(UIScreen.main.bounds.size), overallTolerance: Snapshot.tolerance) + + } + + func testDefaultBarDataSetLabels() + { + let dataEntries = setupDefaultValuesDataEntries() + let dataSet = BarChartDataSet(entries: dataEntries) + dataSet.drawIconsEnabled = false + let chart = setupDefaultChart(dataSets: [dataSet]) + ChartsSnapshotVerifyView(chart, identifier: Snapshot.identifier(UIScreen.main.bounds.size), overallTolerance: Snapshot.tolerance) } func testZeroValues() diff --git a/Tests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultBarDataSetLabels_iOS_375_0_667_0@2x.png b/Tests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultBarDataSetLabels_iOS_375_0_667_0@2x.png new file mode 100644 index 0000000000..399cb61016 Binary files /dev/null and b/Tests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultBarDataSetLabels_iOS_375_0_667_0@2x.png differ diff --git a/Tests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultBarDataSetLabels_tvOS_1920_0_1080_0@1x.png b/Tests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultBarDataSetLabels_tvOS_1920_0_1080_0@1x.png new file mode 100644 index 0000000000..8804298654 Binary files /dev/null and b/Tests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultBarDataSetLabels_tvOS_1920_0_1080_0@1x.png differ