deprecate [dependabot] badges #7274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
added
service-badge
|
chris48s
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7267
The more I've thought about it, the more I see no way around deprecating this current badge (barring a wild reverse course from GitHub). The API we've been consuming is part of the legacy Dependabot infrastructure, never guaranteed backwards compatibility, and was slated to be shut down a few weeks ago - https://github.com/dependabot/api-docs#dependabot-api-docs (though I'm guessing they waited a bit longer to shut it down/redirect requests to the new endpoint based on when we first started seeing failures)
If someone really wants to make a case for a new badge that incorporates the now mandatory old/new versions for comparison that can be considered at that time. However, we can't really do anything with the current badge as there wouldn't even be a way to map the current badge/route to that hypothetical (and seemingly useless) one, given that we can't presume/make up version values