Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [github] release/tag/download schema #7170

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

chris48s
Copy link
Member

closes #7169
by default Joi.string() doesn't allow ''

@chris48s chris48s added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Oct 18, 2021
@shields-ci
Copy link

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 1679bad

@chris48s
Copy link
Member Author

The failing service test is because the test is looking at the number of downloads for a release which currently has 0 downloads 😆 so https://img.shields.io/github/downloads-pre/photonstorm/phaser/latest/total is failing the isMetric validator. I just downloaded the release a few times so it should probably pass if we restart it in a bit and the counter updates

@calebcartwright calebcartwright merged commit a8214b7 into badges:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub release (latest by date) returns invalid response data
3 participants