support gitlab token via env var #7023
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chris48s
approved these changes
Sep 16, 2021
|
Yeah docs on this are a good shout 👍 I think a new config var usually needs adding to
so there's definitely some scope to mess that up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was banging my head against the desk trying to figure out why the Shields.io prod environment wasn't sending the auth info with gitlab.com bound requests... only to discover I left out this crucial piece 🤦♂️
I've been meaning to suggest some documentation for adding new server secrets, as I think it'd be a helpful reference for folks, plus I've clearly forgotten it myself on more than one occasion!