Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report- cannot remove tags created at level 0 #1972

Open
1 task done
andywilde opened this issue May 8, 2024 · 0 comments
Open
1 task done

Bug report- cannot remove tags created at level 0 #1972

andywilde opened this issue May 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@andywilde
Copy link

andywilde commented May 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Version of the module you are using

5.7.2

Rover Version

aztfmod/rover:1.4.6-2305.180

Terraform Version

No response

AzureRM Provider Version

No response

Affected Resource(s)/Data Source(s)

multiple resources

Terraform Configuration Files

default_region = "region1"

# all resources deployed will inherit tags from the parent resource group
inherit_tags = true

landingzone = {
  backend_type = "azurerm"
  level        = "level0"
  key          = "launchpad"
}

enable = {
  bastion_hosts    = false
  virtual_machines = false
}

regions = {
  region1 = "uksouth"
  region2 = "ukwest"
  region3 = "westeurope"
}


tags = {
  owner               = "XXXXXXXXXX"
  cost_center         = "XXXXXXXXXX"
  environment         = "prod"
  data_classification = "internal"
  criticality         = "high"
  business_unit       = "XXXXXXXXX"
  ops_commitment      = "platform operations"
  ops_team            = "cloud operations"
  deployment_type     = "terraform"
  dr                  = "essential"
  service_class       = "gold"
}

launchpad_key_names = {
  azuread_app            = "XXXXX"
  keyvault_client_secret = "XXXXX"

  tfstates = [
    "level0",
    "level1",
    "level2",
    "level3",
    "level4"
  ]
}

Expected Behaviour

After the tags ops_commitment and ops_team tags are removed from the level 0 configuration and these tags are removed from all resource and resource groups using the Azure Portal or CLI, I would not expect the tags to regenerated.

Actual Behaviour

Tags are being recreated on multiple resources.

Steps to Reproduce

  1. Remove tags from level 0 CAF configuration and ensure they are not declared at any other level.
  2. Remove tags from all resources and resource groups using Azure Portal and/or azure CLI
  3. Run all CAF pipelines to propagate changes to all levels

Important Factoids

References

No response

@andywilde andywilde added the bug Something isn't working label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant