Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alternative deploy strategy #25

Open
zimme opened this issue Oct 11, 2022 · 5 comments
Open

Add support for alternative deploy strategy #25

zimme opened this issue Oct 11, 2022 · 5 comments

Comments

@zimme
Copy link
Contributor

zimme commented Oct 11, 2022

I've been thinking about an alternative deployment strategy.

  • Create new storage zone
    • Use git commit sha in the storage zone name probably
  • Upload files to new storage zone
  • Update pull zone to use new storage zone
  • Remove old storage zone
    • Config for how many previous storage zones to keep

As this approach is quite different from the current one perhaps this would be better implemented as a separate action.

Thoughts?

@ayeressian
Copy link
Owner

Hi @zimme, what do you mean by saying "old storage zone"? When this strategy is going to be useful? Can you elaborate more?

@zimme
Copy link
Contributor Author

zimme commented Oct 15, 2022

The current deployment strategy supported by this GitHub Action is to always upload to the same storage zone and replace files.

The alternative strategy would involve always creating a new storage zone and always uploading to a new storage zone and then reconfigure the pull zone to use the new storage zone as the origin.

It would become very simple to "rollback" to a previous deployment with this strategy if you keep at least some of the "old" storage zones that have the files for old releases, by just changing the pull zone's origin setting.

@ayeressian
Copy link
Owner

There are 2 operations that are missing for the deployment strategy that you described to work

  1. Create a new storage zone
  2. Redirect the pull zone

Those 2 operations either can be implemented as separate actions or integrated into the current action. I think having separate actions for those is a bit overkill. But I need some time to think about it.

@mhaamann
Copy link
Contributor

How far did you guys come with this deploy strategy @ayeressian & @zimme? I have been thinking about a similar strategy to have quick rollbacks. Any learnings?

@zimme
Copy link
Contributor Author

zimme commented Sep 26, 2023

Just talk and no action from my side yet. Still interested in the idea, but no time to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants