Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove archived dependency on github.com/pkg/errors #321

Closed
djdongjin opened this issue Jan 17, 2023 · 2 comments · Fixed by #325
Closed

Remove archived dependency on github.com/pkg/errors #321

djdongjin opened this issue Jan 17, 2023 · 2 comments · Fixed by #325
Assignees
Labels
feature New feature or request

Comments

@djdongjin
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The dependency repo (https://github.com/pkg/errors) has been archived and the functionality it provides is implemented in builtin errors pkg.

Describe the solution you'd like

Remove this dependency and use builtin errors pkg directly.

https://github.com/search?q=repo%3Aawslabs%2Fsoci-snapshotter%20%22github.51.al%2Fpkg%2Ferrors%22&type=code

Additional context

Similar issue in containerd repo: containerd/containerd#7940

Sample PR to remove the dependency: containerd/btrfs#35

@djdongjin djdongjin added the feature New feature or request label Jan 17, 2023
@Kern--
Copy link
Contributor

Kern-- commented Jan 17, 2023

Please take note of wherever we're using errors.Is following this change and double check that there is test coverage for that branching. If not, please file additional issues.

@djdongjin
Copy link
Contributor Author

Please take note of wherever we're using errors.Is following this change and double check that there is test coverage for that branching. If not, please file additional issues.

Created #326 which has a summary of errors.Is usage and test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants