Add Content-Length required header to request protocol tests #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Content-Length as an expected header to be serialized in AWS protocol requests for structured and blob payloads.
mtdowling
reviewed
Jul 10, 2020
| @@ -31,6 +31,9 @@ apply HttpPayloadTraits @httpRequestTests([ | |||
| headers: { | |||
| "X-Foo": "Foo" | |||
| }, | |||
| requireHeaders: [ | |||
There was a problem hiding this comment.
👍 Since this blob is not streaming, this makes sense
mtdowling
approved these changes
Jul 10, 2020
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Jul 13, 2020
Adds the ContentLengthMiddleware to the operation's stack, and updates generated clients and protocol tests to use the content-length check. Depends on: * aws/smithy-go#108 * smithy-lang/smithy#491
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Jul 14, 2020
Adds the ContentLengthMiddleware to the operation's stack, and updates generated clients and protocol tests to use the content-length check. Depends on: * aws/smithy-go#108 * smithy-lang/smithy#491
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Jul 15, 2020
Adds the ContentLengthMiddleware to the operation's stack, and updates generated clients and protocol tests to use the content-length check. Depends on: * aws/smithy-go#108 * smithy-lang/smithy#491
skmcgrail
pushed a commit
to skmcgrail/aws-sdk-go-v2
that referenced
this pull request
Aug 21, 2020
Adds the ContentLengthMiddleware to the operation's stack, and updates generated clients and protocol tests to use the content-length check. Depends on: * aws/smithy-go#108 * smithy-lang/smithy#491
skmcgrail
pushed a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Sep 24, 2020
Adds the ContentLengthMiddleware to the operation's stack, and updates generated clients and protocol tests to use the content-length check. Depends on: * aws/smithy-go#108 * smithy-lang/smithy#491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Content-Length as an expected header to be serialized in AWS protocol requests for structured and blob payloads.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.