Add service closure name conflict validation #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Mar 31, 2020
...model/src/main/java/software/amazon/smithy/model/validation/validators/ServiceValidator.java
Outdated
Show resolved
Hide resolved
...model/src/main/java/software/amazon/smithy/model/validation/validators/ServiceValidator.java
Outdated
Show resolved
Hide resolved
This commit validates and standardizes the behavior that has existed for many years in AWS SDKs: requiring that shapes in the closure of a service are case-insensitively unique regardless of their namespaces (with some exceptions for simple types and lists/sets). This change ensures that SDK code gen does not need to persist the namespaces in their generated code, and that they can create their own namespaced/siloed copies of shapes for each service (removing the need to publish and pull in dependencies on shared types).
mtdowling
force-pushed
the
service-closure-name-validation
branch
from
7b6bfe8
to
f664b82
Compare
kstich
approved these changes
Mar 31, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit validates and standardizes the behavior that has existed for
many years in AWS SDKs: requiring that shapes in the closure of a
service are case-insensitively unique regardless of their namespaces
(with some exceptions for simple types and lists/sets). This change
ensures that SDK code gen does not need to persist the namespaces in
their generated code, and that they can create their own
namespaced/siloed copies of shapes for each service (removing the need
to publish and pull in dependencies on shared types).
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.