Allow authType to be specified #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets customers specify the `authType` themselves. Previously we had always set it to `awsSigv4` or `custom` (depending on the scheme), and that behavior is still the default.
mtdowling
requested changes
Sep 11, 2019
...-traits/src/main/java/software/amazon/smithy/aws/traits/apigateway/AuthorizerDefinition.java
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
custom-auth-type
branch
from
0660fa2
to
0b38975
Compare
kstich
approved these changes
Sep 12, 2019
mtdowling
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets customers specify the
authTypethemselves. Previously wehad always set it to
awsSigv4orcustom(depending on thescheme), and that behavior is still the default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.