Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove kitchen sink example #180

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Sep 25, 2020

Issue #, if available: #118

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #180 into develop will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #180      +/-   ##
===========================================
- Coverage   100.00%   99.86%   -0.14%     
===========================================
  Files           52       52              
  Lines         2154     2154              
  Branches        97       97              
===========================================
- Hits          2154     2151       -3     
- Misses           0        3       +3     
Impacted Files Coverage Δ
aws_lambda_powertools/tracing/extensions.py 25.00% <0.00%> (-75.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ff6bc9...b10af63. Read the comment docs.

@heitorlessa
Copy link
Contributor Author

updated cookiecutter example with dummy example, and issues to enhance the example so it becomes a functional example over a kitchen sink: https://github.com/aws-samples/cookiecutter-aws-sam-python

@heitorlessa heitorlessa merged commit eac89af into aws-powertools:develop Sep 25, 2020
@heitorlessa heitorlessa deleted the chore/remove-example branch September 25, 2020 15:12
@heitorlessa heitorlessa added the internal Maintenance changes label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants