Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emf multiple metric values #167

Merged
merged 6 commits into from
Sep 18, 2020
Merged

Conversation

to-mc
Copy link
Contributor

@to-mc to-mc commented Sep 17, 2020

Issue #, if available: #165

Description of changes:

Update metrics utility to support multiple values for the same metric name.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@to-mc to-mc changed the title Feat/emf multiple metric values feat: emf multiple metric values Sep 17, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020

Codecov Report

Merging #167 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #167   +/-   ##
========================================
  Coverage    99.79%   99.79%           
========================================
  Files           39       39           
  Lines          996      999    +3     
  Branches        83       83           
========================================
+ Hits           994      997    +3     
  Misses           1        1           
  Partials         1        1           
Impacted Files Coverage Δ
aws_lambda_powertools/metrics/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee14b1...a6300f8. Read the comment docs.

@heitorlessa
Copy link
Contributor

NOTE: Don't forget to label this PR, and update Changelog

@to-mc to-mc added area/metrics feature New feature or functionality and removed enhancement labels Sep 18, 2020
@to-mc to-mc merged commit a25e3b1 into develop Sep 18, 2020
@to-mc to-mc deleted the feat/emf_multiple_metric_values branch September 18, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants