From 33f5f7b9310b62449fa195ae4a3f6b7511c76ea6 Mon Sep 17 00:00:00 2001 From: Peter Thomas Date: Thu, 7 Mar 2024 17:59:45 +0000 Subject: [PATCH 1/2] chore: remove code smell from unneeded f string interpolation --- hack/generate-template-variable-doc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/generate-template-variable-doc.py b/hack/generate-template-variable-doc.py index 6459faf96..1416d58e9 100755 --- a/hack/generate-template-variable-doc.py +++ b/hack/generate-template-variable-doc.py @@ -38,7 +38,7 @@ def update_doc(doc: str, template_path: str) -> str: for var, val in all_vars.items(): if val is not None: if val == "": - val = f"`\"\"`" + val = "`\"\"`" else: val = f"```{val}```" else: From 3ac8d78a7e79ebd137692498214664254c3e48b8 Mon Sep 17 00:00:00 2001 From: Peter Thomas Date: Thu, 7 Mar 2024 18:13:18 +0000 Subject: [PATCH 2/2] chore: fixing code smell in test DockerFile --- templates/test/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/test/Dockerfile b/templates/test/Dockerfile index 00d2775b5..a7dd78bd4 100644 --- a/templates/test/Dockerfile +++ b/templates/test/Dockerfile @@ -1,4 +1,4 @@ -FROM public.ecr.aws/aws-ec2/amazon-ec2-metadata-mock:v1.11.2 as aemm +FROM public.ecr.aws/aws-ec2/amazon-ec2-metadata-mock:v1.11.2 AS aemm FROM public.ecr.aws/amazonlinux/amazonlinux:2 RUN amazon-linux-extras enable docker && \ yum install -y jq containerd wget which && \