Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .promise() pattern for RDS.Signer.getAuthToken #3595

Closed
willfarrell opened this issue Jan 10, 2021 · 5 comments
Closed

Support .promise() pattern for RDS.Signer.getAuthToken #3595

willfarrell opened this issue Jan 10, 2021 · 5 comments
Labels
closed-for-staleness feature-request A feature should be added or improved.

Comments

@willfarrell
Copy link

Is your feature request related to a problem? Please describe.
Currently I need to do the following:

const signer = new RDS.Signer(config)
    return new Promise((resolve, reject) => {
      signer.getAuthToken({}, (err, token) => {
        if (err) {
          reject(err)
        }
        resolve(token)
      })
    })
    ```


**Describe the solution you'd like**
I would like to do:
```javascript
const signer = new RDS.Signer(config)
    return  signer.getAuthToken({}).promise()

Describe alternatives you've considered
See top of issue for current workaround. I looked into using v3 but RDS.Signer is not supported.

Additional context
This API is inconsistent with how other API are handled.

@willfarrell willfarrell added the feature-request A feature should be added or improved. label Jan 10, 2021
@willfarrell willfarrell mentioned this issue Jan 10, 2021
63 tasks
@willfarrell willfarrell changed the title Support .promise() pattern for RDS.Signer. signer.getAuthToken Support .promise() pattern for RDS.Signer.getAuthToken Jan 24, 2021
@ajredniwja
Copy link
Contributor

Hey @willfarrell thanks for opening this feature request.

Note: The version 3.x of the AWS SDK for JavaScript is generally available.
For more information see the Developer Guide
or API Reference.

@willfarrell
Copy link
Author

I would consider using the v3 SDK, however RDS.Signer isn't supported. aws/aws-sdk-js-v3#1823

@ajredniwja
Copy link
Contributor

Thanks for mentioning that issue, It would more likely be implemented in V3 first as that is the SDK that is being actively being worked on.

@clafollett
Copy link

I know I could definitely use the functionality of RDS.Signer in v3!!!

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Mar 2, 2022
@github-actions github-actions bot closed this as completed Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants