-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Java SDK 1.12.506 and 1.12.507 endpoints.json broken for savingsplans #3008
Comments
@bgiaccio thank you for the detailed report. Yes, SavingsPlans signature is broken, we'll work on a fix. |
The issue is fixed in 1.12.510 |
@bgiaccio please let us know if you see any issues after the fix. |
Confirmed your fix. |
Thank you for the follow-up. Resolving this. |
COMMENT VISIBILITY WARNINGComments on closed issues are hard for our team to see. |
Describe the bug
Using the java sdk to call describeSavingsPlans from any commercial region the signingRegion is computed as us-gov-west-1. After debugging we determined the problem is a recent commit to endpoints.json#L22715-L22726
Which is related to the comment
// Assume the same hostname will never be in two different partitions.
found in PartitionMetadataProvider.java#L65
Now endpoints JSON violates that assumption as the hostname appears in the first and 3rd partitions of endpoints.json
Expected Behavior
When asking to describe savings plans in a commercial region like us-east-1 the savings plans are returned
Current Behavior
The wire logs contain
Reproduction Steps
Executing this with 1.12.504 returns results, switching to 506 produces an error
Possible Solution
Either endpoints json needs to be updated with the proper endpoint for us-gov-west-1 or the code in PartitionMetadataProvider will have to be updated to keep the data separate by partition
Additional Information/Context
No response
AWS Java SDK version used
1.12.506
JDK version used
openjdk 20.0.1 2023-04-18
Operating System and version
MacOS 13.4.1 and Redhat 8.8
The text was updated successfully, but these errors were encountered: