Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolvedEndpoint.URL should specify if you need to include the leading scheme #4339

Closed
kevinburkesegment opened this issue Mar 30, 2022 · 6 comments
Labels
documentation This is a problem with documentation.

Comments

@kevinburkesegment
Copy link

There are many different ways to specify a URL, it would be helpful to know if all you want in the endpoint is a hostname, hostname/port or if you need the leading scheme as well.

@kevinburkesegment kevinburkesegment added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Mar 30, 2022
@vudh1
Copy link
Contributor

vudh1 commented Apr 22, 2022

Hi @kevinburkesegment please follow this template to help us understand more what you are looking for in the documentation fix. More description/information is helpful.

@vudh1 vudh1 added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 22, 2022
@github-actions
Copy link

This issue has not received a response in 1 week. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Apr 25, 2022
@kevinburkesegment
Copy link
Author

In aws/endpoints/endpoints.go, here is the documentation for ResolvedEndpoint

// A ResolvedEndpoint is an endpoint that has been resolved based on a partition
// service, and region.
type ResolvedEndpoint struct {
	// The endpoint URL
	URL string

But there are lots of different ways a URL could be specified, with just a domain, with a scheme, with a path etc.

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Apr 26, 2022
@github-actions
Copy link

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Apr 26, 2023
@kevinburkesegment
Copy link
Author

This is still an issue

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Apr 27, 2023
@lucix-aws lucix-aws closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

No branches or pull requests

3 participants