Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical resource names #1829

Closed
eladb opened this issue Feb 21, 2019 · 3 comments
Closed

Physical resource names #1829

eladb opened this issue Feb 21, 2019 · 3 comments
Labels
@aws-cdk/core Related to core CDK functionality package/awscl Cross-cutting issues related to the AWS Construct Library

Comments

@eladb
Copy link
Contributor

eladb commented Feb 21, 2019

This topic discusses support for physical resource names in the AWS Construct Library

@eladb
Copy link
Contributor Author

eladb commented Feb 21, 2019

@skinny85 Our little pet project made me realize we need rich support for physical names in L2s. For example, I would have expected that if I supply a physical name to a quque for example upon construction, then both queueName and queueArn and queueUrl will resolve during synthesis and not during deployment.

@rix0rrr this makes me realize your intuition was correct, we need to "wrap" all the L2 attributes with magical tokens that can resolve to physical names (and move the cross stuff references from L1 to L2). The heuristics of producing a queueURL and queueARN from a queueName is something that each L2 will need to supply, and that is also the same heuristics we can apply when we import a resource and only support one of these attributes.

@RomainMuller
Copy link
Contributor

We need to make sure to continue using the Ref/Fn::GetAtt output when rendering references in-stack, and probably also in-region in-account cross-stack, so we get the CloudFormation-provided dependency orchestration at no additional cost.

@eladb eladb added the @aws-cdk/core Related to core CDK functionality label Feb 28, 2019
@eladb eladb added the package/awscl Cross-cutting issues related to the AWS Construct Library label Apr 15, 2019
@eladb
Copy link
Contributor Author

eladb commented Apr 15, 2019

Superseded by #2283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality package/awscl Cross-cutting issues related to the AWS Construct Library
Projects
None yet
Development

No branches or pull requests

3 participants