Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api-gateway): add support for new router feature #767

Merged
merged 18 commits into from
Nov 12, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Oct 17, 2021

Issue #, if available:

Description of changes:

Add docs on how to use the new Router decorator for the API Gateway Resolvers

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/core/event_handler/api_gateway.md

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation tests labels Oct 17, 2021
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2021

Codecov Report

Merging #767 (a442472) into develop (1bcd4ff) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #767      +/-   ##
===========================================
- Coverage    99.98%   99.90%   -0.08%     
===========================================
  Files          118      118              
  Lines         5097     5107      +10     
  Branches       277      279       +2     
===========================================
+ Hits          5096     5102       +6     
- Misses           0        2       +2     
- Partials         1        3       +2     
Impacted Files Coverage Δ
...ools/utilities/idempotency/persistence/dynamodb.py 94.66% <0.00%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bcd4ff...a442472. Read the comment docs.

@michaelbrewer michaelbrewer changed the title docs(api-gateway): Add docs for the new router fetch docs(api-gateway): Add docs for the new router feature Oct 17, 2021
@michaelbrewer michaelbrewer marked this pull request as ready for review October 18, 2021 02:28
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep /users and /health only, and focus on a diagram to show how it's interconnected, and on trade-offs in general (fat vs thin)

@michaelbrewer
Copy link
Contributor Author

Let's keep /users and /health only, and focus on a diagram to show how it's interconnected, and on trade-offs in general (fat vs thin)

@heitorlessa - this was done. We will have to do something similar for the AppSync PR (or refer these docs)

Michael Brewer and others added 4 commits October 25, 2021 10:13
…uter

* michaelbrewer/docs/router:
  feat(data-classes): ActiveMQ and RabbitMQ support (aws-powertools#770)
  feat(appsync): add Router to allow large resolver composition (aws-powertools#776)
  chore(deps-dev): bump mkdocs-material from 7.3.3 to 7.3.5 (aws-powertools#781)
  chore(deps-dev): bump flake8-isort from 4.0.0 to 4.1.1 (aws-powertools#785)
  chore(deps): bump urllib3 from 1.26.4 to 1.26.5 (aws-powertools#787)
  chore(deps-dev): bump flake8-eradicate from 1.1.0 to 1.2.0 (aws-powertools#784)
  chore(deps): bump boto3 from 1.18.61 to 1.19.6 (aws-powertools#783)
  chore(deps-dev): bump pytest-asyncio from 0.15.1 to 0.16.0 (aws-powertools#782)
  docs: fix indentation of SAM snippets in install section (aws-powertools#778)
  Fix middleware sample (aws-powertools#772)
  Removed unused import, added typing imports, fixed typo in example. (aws-powertools#774)
  Fix middleware sample (aws-powertools#772)
  Removed unused import, added typing imports, fixed typo in example. (aws-powertools#774)
  Update docs/core/event_handler/api_gateway.md

# Conflicts:
#	docs/core/event_handler/api_gateway.md
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@heitorlessa heitorlessa changed the title docs(api-gateway): Add docs for the new router feature docs(api-gateway): add support for new router feature Nov 12, 2021
@heitorlessa heitorlessa merged commit d62b0a0 into aws-powertools:develop Nov 12, 2021
@heitorlessa heitorlessa deleted the docs/router branch November 12, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants