fix(parser): apigw wss validation check_message_id; housekeeping #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Add some more unit tests - Fix bug with `check_message_id` not looking in the RequestContext - Add more mypy coverage - Add pragma: no cover
|
@risenberg-cyberark - can you check the apigw fix I made for the validation. |
Codecov Report
@@ Coverage Diff @@
## develop #553 +/- ##
===========================================
+ Coverage 99.86% 99.95% +0.08%
===========================================
Files 113 113
Lines 4485 4477 -8
Branches 243 243
===========================================
- Hits 4479 4475 -4
+ Misses 3 0 -3
+ Partials 3 2 -1
Continue to review full report at Codecov.
|
ran-isenberg
suggested changes
Jul 22, 2021
michaelbrewer
commented
Jul 22, 2021
michaelbrewer
commented
Jul 22, 2021
michaelbrewer
commented
Jul 22, 2021
|
btw, the code coverage is insane :) @michaelbrewer |
pull-request-size
bot
added
the
size/M
|
@heitorlessa i will leave out the other possible type checking and validation checks for idempotent for another time |
michaelbrewer
changed the title
heitorlessa
approved these changes
Jul 30, 2021
| if i < max_handler_retries: | ||
| continue | ||
| else: | ||
| if i == max_handler_retries: |
heitorlessa
changed the title
heitorlessa
added a commit
that referenced
this pull request
Jul 30, 2021
* develop: feat(params): expose high level max_age, raise_on_transform_error (#567) fix(parser): apigw wss validation check_message_id; housekeeping (#553) chore(deps-dev): bump isort from 5.9.2 to 5.9.3 (#574) feat(data-classes): decode json_body if based64 encoded (#560) chore(deps-dev): bump mkdocs-material from 7.2.0 to 7.2.1 (#566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Various housekeeping, code coverage and mypy tasks
Changes:
check_message_idnot validating against the RequestContextcheck_message_idpragma: no coveridempotency.pyand remove unusedmax_handler_retriespropertyChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.