Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-identity-token-file is not in v1, but readme says it is #266

Closed
mhenderson-t2 opened this issue Sep 23, 2021 · 6 comments
Closed

web-identity-token-file is not in v1, but readme says it is #266

mhenderson-t2 opened this issue Sep 23, 2021 · 6 comments

Comments

@mhenderson-t2
Copy link

The readme indicates that web-identity-token-file is present in @v1

You can configure your workflow as follows in order to use this file:

uses: aws-actions/configure-aws-credentials@v1
with:
  aws-region: us-east-2
  role-to-assume: my-github-actions-role
  web-identity-token-file: /var/run/secrets/eks.amazonaws.com/serviceaccount/token

However it appears this functionality was added 4th August and the module has not been released since then. Hence you cannot use this feature as it is documented.

I have worked around this by

uses: aws-actions/configure-aws-credentials@master

But I cannot recommend this to others, as it does not pin the module to a stable (or released) version. However this may be worth either documenting, or removing the documentation until it has been released.

@Lou1415926
Copy link

Hello @mhenderson-t2 ! Sorry for the late check-in 🙇🏼‍♀️!

Thank you very much for reporting this! Yes, the documentation should be removed until it’s released. We will fix the README as soon as possible.

@diogokiss
Copy link

I'm facing the same issue and my project needs to use Web Identity-based credentials. Is there a workaround to use this feature from a release candidate branch maybe in the meanwhile?

@diogokiss
Copy link

I'm facing the same issue and my project needs to use Web Identity-based credentials. Is there a workaround to use this feature from a release candidate branch maybe in the meanwhile?

I managed to go around the error by using:

      - name: Configure AWS Credentials
        # https://github.com/aws-actions/configure-aws-credentials/issues/266
        uses: aws-actions/configure-aws-credentials@8053174404968575ac1dd102dcb1109d2fe6d9ea

@paragbhingre
Copy link
Contributor

We have now released configure-aws-credentials. V1 will now have the web-identity-token-file related changes.

@peterwoodworth peterwoodworth added needs-triage This issue still needs to be triaged and removed needs-triage This issue still needs to be triaged labels Oct 4, 2022
@peterwoodworth
Copy link
Contributor

This has been released 🙂

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

⚠️Comment Visibility Warning⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants