Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ca file err #460

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Fix ca file err #460

merged 2 commits into from
Mar 29, 2022

Conversation

malud
Copy link
Collaborator

@malud malud commented Mar 29, 2022

fix missing error handling propagation to the callee (run command)


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@malud malud requested a review from johakoch March 29, 2022 10:35
malud pushed a commit that referenced this pull request Mar 29, 2022
@johakoch johakoch merged commit 2c4207a into release.1.8 Mar 29, 2022
@johakoch johakoch deleted the fix-ca-file-err branch March 29, 2022 11:47
malud pushed a commit that referenced this pull request Mar 29, 2022
malud pushed a commit that referenced this pull request Mar 29, 2022
* Prepare the dir-flag and the new env-var + docu

* Merging implementation

* Apply new merging code, fix tests

* Remove debug code

* hcl -> hclsyntax interface

* Fix tests

* Fix verify command

* Fix watch command flag

* Check for unique attrs w/o src bytes

* Cleanup

* Fix test config file

* Fix env context

* Lint

* Extend test files

* Fix abs path

* Remove wrong test files

* Make pathes absolute

* Add tests

* mergeAttributes throws no errors

* Update docs/CLI.md

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>

* Update docs/CLI.md

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>

* added api endpoints to servers to test CORS behaviour

* rename method

* reduce loop complexity

* rename loop vars since they clashes with local type declaration

* rename local variable due to package clash

* rename local vars due to existing const ones

* register settings.ca_file for abs path

* handle abs path in test expectations

* no caps label

* added changelog

* Add ca_file to multi config test; works with #460

* Add additional server block tests

* Fixup

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
Co-authored-by: Johannes Koch <johannes.koch@avenga.com>
Co-authored-by: Marcel Ludwig <marcel.ludwig@avenga.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants