Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom logs (new implementation) #388

Merged
merged 33 commits into from
Dec 1, 2021
Merged

Custom logs (new implementation) #388

merged 33 commits into from
Dec 1, 2021

Conversation

alex-schneider
Copy link
Contributor

@alex-schneider alex-schneider commented Nov 23, 2021 •
edited by malud
Loading

add custom_log_fields attribute to blocks be able to describe a user defined map for custom log field enrichment.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

malud
malud reviewed Nov 29, 2021
View reviewed changes
handler/error.go Outdated Show resolved Hide resolved
Alex Schneider and others added 25 commits November 30, 2021 07:44
Prepare HCL config
de77cc6
Fix gostatic warnings
273bc4d
New converter functions
9f88f6e
Docu
e93fe29
Add custom logs to the context
bcd7b27
Add new handler
4d82d85
Implement custom logging :: DRAFT
e0bb9b3
Tests
12a0138
Fix nil definitions block
e2b5c59
Fix file muxing
f1d7b92
Fix handler names for logging :: DRAFT
761917f
Fulfill Child interface requirements
8388e38
Fix using the context
5e817d6
Use another context for access log
5d962ce
check interface assertion, reduce condition complexity
70723c6
Refactor accesslog interface, does not serve http
aec0d45
refactor custom log channel usage for eval context with beresps
f381f67
Format method signature
47cef0b
Fix test panic indexing on nil obj
66012e1
Add basic auth block support for custom_logs
4cee666
Handle error_handler custom_logs content by event
8f3bfa5
Fix logging for wildcard cases, add tests
816c783
Fix configurable logging type fields
a426d00
remove todo; fmt code
114e481
Refactor error_handler context update to own method
12d02c6
@malud malud merged commit 64bd2d3 into master Dec 1, 2021
@malud malud deleted the new-custom-logs branch December 1, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-schneider @malud