Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new srv to capture screen shot and movie #121

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Sep 20, 2024

Description

I added new srv type to capture screen shot or movie by external trigger.

uint8 SCREEN_SHOT = 0
uint8 START_BUFFERING = 1
uint8 STOP_BUFFERING = 2
uint8 RECORD = 3
uint8 SAVE = 4
uint8 SAVE_BUFFER = 5

uint8 action
string file_name

---

bool success

Related links

Tests performed

screen shot

ros2 service call /debug/capture tier4_screen_capture_rviz_plugin/srv/Capture "{action: 0, file_name: "test"}"
movie-2024-09-25_18.53.09.mp4

capture movie

start recording

ros2 service call /debug/capture tier4_screen_capture_rviz_plugin/srv/Capture "{action: 3, file_name: ""}"

save

ros2 service call /debug/capture tier4_screen_capture_rviz_plugin/srv/Capture "{action: 4, file_name: "test-2"}"
movie-2024-09-25_18.53.55.mp4

buffering screen capture

start buffering

ros2 service call /debug/capture tier4_screen_capture_rviz_plugin/srv/Capture "{action: 1, file_name: ""}"

save

ros2 service call /debug/capture tier4_screen_capture_rviz_plugin/srv/Capture "{action: 5, file_name: "buffer"}"
movie-2024-09-25_18.55.12.mp4

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants