fix(system_error_monitor): changed settings of /autoware/localization/performance_monitoring #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
|
@ito-san FYI |
YamatoAndo
approved these changes
Feb 15, 2024
SakodaShintaro
merged commit 59556db
into
autowarefoundation:main
9 of 10 checks passed
This was referenced Feb 15, 2024
yuki-takagi-66
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Jul 3, 2024
…autowarefoundation#877) fix: use default vehicle_model_steer_tau in simulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed settings in system_error_monitor
localization_stability is a feature added below.
This change was not reflected in
system_error_monitor.param.yaml, so this pull request added it.I also fixed
system_error_monitor.awsim.param.yamlbecause it did not take into account other added metrics.Tests performed
AWSIM + Autoware works fine.
Effects on system behavior
localization_stability has almost no effect as it does not output ERROR level diag.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.