Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rviz): update the class name and turn signal color #855

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

KhalilSelyan
Copy link
Contributor

@KhalilSelyan KhalilSelyan commented Feb 6, 2024

Description

Changing class name of the overlay plugin + turn signals default color

Part of:

Should be merged with:

Tests performed

Not applicable.

Effects on system behavior

This will correctly load the plugin into the display

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
@xmfcx xmfcx force-pushed the update/autoware.rviz-default-file branch from 6b35aab to db71c77 Compare February 6, 2024 11:37
@xmfcx xmfcx changed the title fix: new class name and turn signal colors updated refactor(rviz): update the class name and turn signal color Feb 6, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Feb 6, 2024

Renamed the PR title and the commit message to reflect the meaning better.

@xmfcx xmfcx merged commit 86c9f00 into main Feb 7, 2024
13 of 14 checks passed
@xmfcx xmfcx deleted the update/autoware.rviz-default-file branch February 7, 2024 09:58
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jun 5, 2024
…herry-pick-avoidance-pr

fix: cherry pick avoidance PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants