Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): rework parameters #847

Conversation

Motsu-san
Copy link
Contributor

Description

This is the accompanied pull request of autoware.universe one.
Please see the description of the main pull request.

Tests performed

confirm parameters

  1. run autoware & replay rosbag that can start localization(Autoware sample rosbag is recommended).
  2. command the following
ros2 param dump /localization/pose_twist_fusion_filter/ekf_localizer 

expected result

/localization/pose_twist_fusion_filter/ekf_localizer:
  ros__parameters:
    diagnostics:
      pose_no_update_count_threshold_error: 100
      pose_no_update_count_threshold_warn: 50
      twist_no_update_count_threshold_error: 100
      twist_no_update_count_threshold_warn: 50
    misc:
      threshold_observable_velocity_mps: 0.0
    node:
      enable_yaw_bias_estimation: true
      extend_state_step: 50
      predict_frequency: 50.0
      publish_tf: true
      show_debug_info: false
      tf_rate: 50.0
    pose_frame_id: map
    pose_measurement:
      pose_additional_delay: 0.0
      pose_gate_dist: 10000.0
      pose_smoothing_steps: 5
    process_noise:
      proc_stddev_vx_c: 10.0
      proc_stddev_wz_c: 5.0
      proc_stddev_yaw_c: 0.005
    qos_overrides:
      /clock:
        subscription:
          depth: 1
          durability: volatile
          history: keep_last
          reliability: best_effort
      /parameter_events:
        publisher:
          depth: 1000
          durability: volatile
          history: keep_last
          reliability: reliable
      /tf:
        publisher:
          depth: 100
          durability: volatile
          history: keep_last
          reliability: reliable
    simple_1d_filter_parameters:
      pitch_filter_proc_dev: 0.01
      roll_filter_proc_dev: 0.01
      z_filter_proc_dev: 1.0
    twist_measurement:
      twist_additional_delay: 0.0
      twist_gate_dist: 10000.0
      twist_smoothing_steps: 2
    use_sim_time: true

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
@Motsu-san Motsu-san force-pushed the refactor/rework_parameter_ekf_localizer branch from 261f176 to 2040ef0 Compare February 5, 2024 00:54
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

@Motsu-san
Copy link
Contributor Author

@KYabuuchi Thank you for your review!

@Motsu-san Motsu-san merged commit 6b75cf2 into autowarefoundation:main Feb 6, 2024
9 of 10 checks passed
@Motsu-san Motsu-san deleted the refactor/rework_parameter_ekf_localizer branch February 6, 2024 00:20
t4-adc pushed a commit to tier4/autoware_launch that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants