Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light_recognition): add tlr args in tier4_perception_component.launch.xml #840

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Jan 31, 2024

Description

Add TLR related arguments to tier4_perception_component.launch.xml

Tests performed

Not applicable.

Effects on system behavior

No effects

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ponent.launch.xml

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh requested a review from kminoda February 1, 2024 04:48
@miursh miursh marked this pull request as ready for review February 1, 2024 04:48
@miursh miursh force-pushed the feat/traffic_light_recognition/add_tlr_args branch from 4bf165f to b0b5536 Compare February 1, 2024 05:30
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh force-pushed the feat/traffic_light_recognition/add_tlr_args branch from b0b5536 to 0d0d525 Compare February 1, 2024 05:34
@kminoda
Copy link
Contributor

kminoda commented Feb 1, 2024

@miursh I've confirmed that

  • With the default args, Autoware launches successfully and the traffic light estimation results are published as intended
  • With traffic_light_recognition/enable_fine_detection:=false, Autoware launches without traffic_light_fine_detector

@miursh
Copy link
Contributor Author

miursh commented Feb 1, 2024

@kminoda
Thank you for your support. If possible, could you check with AWSIM to ensure that TLR runs without fine_detector?

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image
image

@miursh miursh merged commit b422b3c into autowarefoundation:main Feb 6, 2024
9 of 10 checks passed
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
@miursh miursh deleted the feat/traffic_light_recognition/add_tlr_args branch July 9, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants