Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(image_projection_based_fusion): rework parameters #824

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 25, 2024

Description

See autowarefoundation/autoware.universe#6169

Tests performed

See autowarefoundation/autoware.universe#6169

Effects on system behavior

See autowarefoundation/autoware.universe#6169

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title chore(image_projection_based_fusion): use config chore(image_projection_based_fusion): rework parameters Jan 25, 2024
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 700b997 into autowarefoundation:main Feb 1, 2024
12 of 13 checks passed
@kminoda kminoda deleted the chore/image_projection_based_fusion/use_config branch February 1, 2024 23:19
zulfaqar-azmi-t4 pushed a commit to tier4/autoware_launch that referenced this pull request Mar 7, 2024
…dation#824)

chore(image_projection_based_fusion): use config

Signed-off-by: kminoda <koji.minoda@tier4.jp>
t4-adc pushed a commit to tier4/autoware_launch that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants