Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perception): add detection_by_tracker param file #676

Conversation

badai-nguyen
Copy link
Contributor

Description

This PR to add param file for autowarefoundation/autoware.universe#5473

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I think we need to wait until autowarefoundation/autoware.universe#5473 is reviewed because rename param name could be suggested. (e.g. ignore_label to label_to_apply or something)

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit 2b25e81 into autowarefoundation:main Nov 13, 2023
9 of 10 checks passed
@badai-nguyen badai-nguyen deleted the fix/detection_by_tracker_param_file branch November 15, 2023 14:54
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
sykwer pushed a commit to sykwer/autoware_launch that referenced this pull request Jan 3, 2024
…owarefoundation#676)

* fix(planning_launch): ignore unavoidable objects around the goal

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning_launch/config/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/avoidance/avoidance.param.yaml

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…ion#548)

* fix(perception): add detection_by_tracker param file (autowarefoundation#676)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: disable DBT for car

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 8, 2024
* fix(perception): add detection_by_tracker param file (autowarefoundation#676)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: disable DBT for car

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants