Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplicated_node_checker): disable duplicated_node_checker #649

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

disable duplicated_node_checker for now.
The reason for this is that simulation fails by enabling this feature.
It should be fixed by preventing double launch, but for now, disable it.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@tkimura4 tkimura4 enabled auto-merge (squash) October 20, 2023 11:44
@tkimura4 tkimura4 merged commit 90c7a6a into main Oct 20, 2023
10 of 11 checks passed
@tkimura4 tkimura4 deleted the feat/disable_duplicated_node_checker branch October 20, 2023 11:46
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 8, 2024
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 8, 2024
fix parameter namespace

remove old parameter file

remove old style parameter file

remove unused parameter

remove duplicated parameter

remove old style parameter

remove old style parameter

pick new style parameter

remove duplicated parameter

remove unnecessary parameter

remove old parameter

Revert "feat: sp tuning for low obstacle (#578)"

This reverts commit f00363f.

Revert "chore(ground_segmentation): reduce ground_segmentation range (autowarefoundation#649)"

This reverts commit 3aacc89.

fix ekf parameter

remove temporary parameter

disable pull over of mrm

change initial_selector_mode to local

reset analytical smoother parameter

remove hazard lights selector

remove l4toolkit

enable stuck vehicle detection in left turn

chore diagnostic_graph_aggregator params

fix module name

chore x2_preset.yaml

fix(static_obstacle_avoidance): parameter tuning

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

fix(slow_down): parameter tuning

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

fix typo

remove duplicated parameter

remove old node

revert common planning param for safety reason.

use mrm_handler as default

relax emergency stop acceleration for safety reason

modify rviz setting

remove l4toolkit from simulation

fix lane change priority

fix behavior velocity planner parameter

make same mpt param as main

update mlmodel parameter style

fix old parameter name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants