Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): lower state_transit_margi_time to 0 #638

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Oct 16, 2023

Description

Now the collision checking in the intersection module is stable, this parameter can be set to zero.

Related links

Tests performed

evaluator: https://evaluation.tier4.jp/evaluation/reports/a6989803-5c35-5eb8-aab4-1e41a803cc2a?project_id=prd_jt

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin merged commit 7d3f1d2 into autowarefoundation:main Oct 17, 2023
10 of 11 checks passed
@soblin soblin deleted the feat/intersection/state_transit_margin branch October 17, 2023 05:08
soblin added a commit that referenced this pull request Oct 17, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…arefoundation#567) (autowarefoundation#638)

* fix: use downsample before compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: remove downsample after compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add low range crop filter param

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
# Conflicts:
#	autoware_launch/config/perception/object_recognition/detection/clustering/voxel_grid_based_euclidean_cluster.param.yaml
#	autoware_launch/config/perception/object_recognition/detection/pointcloud_filter/pointcloud_map_filter.param.yaml
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 18, 2024
…nitor v2.3.2 (autowarefoundation#638)

feat(system_launch): add vehicle heartbeat errors for system error monitor (autowarefoundation#580)

add vehicle heartbeat errors for system error monitor

Signed-off-by: Zhi Wang <zhi.wang@tier4.jp>
Co-authored-by: Zhi Wang <wz.901118@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants