Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): separate execution and cancel safety check param #626

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Oct 6, 2023

Description

Separating safety check parameters for lane change execution and cancel.

Related PR: autowarefoundation/autoware.universe#5246

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
Copy link
Contributor Author

No degradation occured: 1689/1691 failed scenarios are not lane change.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 347b293 into autowarefoundation:main Oct 6, 2023
10 of 11 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat-lc-separate-cancel-parameter branch October 6, 2023 11:16
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Oct 23, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…_negative

feat(euclidean_clustering): update parameter for euclidean clustering
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 18, 2024
)

* need to revert avoidance parameter for some coner cases

* revert parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants