Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(system_error_monitor): rename localization_accuracy #605

Merged

Conversation

Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Sep 29, 2023

Background

This is for the issue autowarefoundation/autoware.universe#3065
This must be merged simultaneously with autowarefoundation/autoware.universe#5178 .

Contents

Rename "localization_accuracy" to localization_error_ellipse

Tests performed

It was confirmed that Build is OK.

Effects on system behavior

Start to display localization_error_ellipse instead of localization_accuracy.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Motsu-san Motsu-san self-assigned this Sep 29, 2023
@Motsu-san Motsu-san linked an issue Sep 29, 2023 that may be closed by this pull request
7 tasks
@Motsu-san Motsu-san changed the title refactor: Rename localization_accuracy refactor(system_error_monitor): Rename localization_accuracy Sep 29, 2023
@Motsu-san Motsu-san added component:localization Vehicle's position determination in its environment. (auto-assigned) component:system System design and integration. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Sep 29, 2023
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link

stale bot commented Nov 28, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Nov 28, 2023
@Motsu-san Motsu-san force-pushed the 3065-rename-localization_accuracy branch from 7f0a12f to 3c95a54 Compare January 4, 2024 07:55
@stale stale bot removed the stale label Jan 4, 2024
@Motsu-san Motsu-san force-pushed the 3065-rename-localization_accuracy branch from 3c95a54 to 00edfcb Compare January 4, 2024 08:02
@Motsu-san Motsu-san marked this pull request as ready for review January 4, 2024 08:30
to localization_error_ellipse

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
@Motsu-san Motsu-san force-pushed the 3065-rename-localization_accuracy branch from 00edfcb to 6c4f530 Compare January 18, 2024 04:17
@Motsu-san Motsu-san changed the title refactor(system_error_monitor): Rename localization_accuracy refactor(system_error_monitor): rename localization_accuracy Jan 18, 2024
@Motsu-san
Copy link
Contributor Author

@ito-san Could you review this pull request?

@YamatoAndo YamatoAndo removed their request for review January 18, 2024 06:47
@Motsu-san Motsu-san enabled auto-merge (squash) January 26, 2024 01:00
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Motsu-san Motsu-san merged commit 8ec9649 into autowarefoundation:main Jan 26, 2024
9 of 11 checks passed
@Motsu-san Motsu-san deleted the 3065-rename-localization_accuracy branch January 26, 2024 04:46
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…handler

* feat: add option to launch mrm handler (autowarefoundation#929)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* chore: add option to select graph path depending on running mode (autowarefoundation#938)

chore: add option of using graph path for simulation

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat: add a param file of a mrm handler node (autowarefoundation#927)

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>

* feat: update config to launch mrm_handler

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat(mrm_handler): enable comfortable stop

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: TetsuKawa <70682030+TetsuKawa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename localization_accuracy
2 participants