Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception): rearrange clustering pipeline parameters #567

Merged

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Sep 14, 2023

Description

This PR updates paramters for #4999

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the fix/rearrange_clustering_pipeline branch from 22dffd8 to 204c62c Compare September 14, 2023 10:55
max_z: 4.5
min_z: -4.5

# low range crop box filter param
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 34e4ac3 into autowarefoundation:main Sep 19, 2023
8 of 10 checks passed
badai-nguyen added a commit to badai-nguyen/autoware_launch that referenced this pull request Sep 21, 2023
…arefoundation#567)

* fix: use downsample before compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: remove downsample after compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add low range crop filter param

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 28, 2023
…lustering-v2.3.0

refactor(perception): rearrange clustering pipeline parameters (autowarefoundation#567)
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
…on#567)

* fix(planning_launch): revise lane change parameters

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* disable collision check at prepare phase

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* enable collision check at prepare and no use all predicted

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* reduced front expected deceleration

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* additional config

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fixed lateral and longitudinal value

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
* feat: use pointpainting instead of centerpoint

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: tkimura4 <tkimura4@users.noreply.github.com>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…arefoundation#567) (autowarefoundation#638)

* fix: use downsample before compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: remove downsample after compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add low range crop filter param

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
# Conflicts:
#	autoware_launch/config/perception/object_recognition/detection/clustering/voxel_grid_based_euclidean_cluster.param.yaml
#	autoware_launch/config/perception/object_recognition/detection/pointcloud_filter/pointcloud_map_filter.param.yaml
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…eset-v3.0.0

feat: planning preset v3.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants