Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): change curvature calculation distance parameter #556

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 8, 2023

Description

For autowarefoundation/autoware.universe#4924

Tests performed

run psim

Effects on system behavior

see autowarefoundation/autoware.universe#4924

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

tkimura4 pushed a commit to tkimura4/autoware_launch that referenced this pull request Sep 8, 2023
autowarefoundation#556)

feat(motion_velocity_smoother): tunable deceleration limit for curve deceleration[

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…parameter

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@tkimura4
Copy link
Contributor

Psim Check

cap-.2023-09-22-16-36-21.mp4
cap-.2023-09-22-17-03-38.mp4

@tkimura4
Copy link
Contributor

@tkimura4 tkimura4 merged commit 6e1174a into autowarefoundation:main Sep 22, 2023
9 of 10 checks passed
@tkimura4 tkimura4 deleted the fix-steer-rate-smoother branch September 22, 2023 08:16
takayuki5168 referenced this pull request in tier4/autoware_launch Oct 2, 2023
…parameter (#556) (#463)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…parameter (autowarefoundation#556)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
…parameter (#556) (#463)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants