Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing_no_drivable_lane_when_module_enabled): add solution for routing no_drivable_lane only when module enabled #457

Conversation

ahmeddesokyebrahim
Copy link
Contributor

Description

This PR is to add as solution for routing no_drivable_lane(s) only when the module is enabled.
Related to this Task

Tests performed

Using planning simulator :

  • When no_drivable_lane is disabled, the routing for no_drivable_lane(s) is not considered
  • When When no_drivable_lane is enabled, routing for no_drivable_lane(s) is considered

Effects on system behavior

Routing for no_drivable_lane(s) is considered only when the module is enabled.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/4307-routing-no-drivable-lane-when-module-enabled branch from 539d673 to 665023c Compare July 20, 2023 09:29
ahmeddesokyebrahim and others added 3 commits July 20, 2023 17:19
…tion

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
…s regarding new parameter

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/4307-routing-no-drivable-lane-when-module-enabled branch from 665023c to ff50ab0 Compare July 20, 2023 14:23
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
@mehmetdogru mehmetdogru merged commit e0c4af6 into autowarefoundation:main Aug 7, 2023
8 of 9 checks passed
@ahmeddesokyebrahim ahmeddesokyebrahim deleted the autoware/launch/4307-routing-no-drivable-lane-when-module-enabled branch August 7, 2023 11:20
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants