Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): add param for the min confidence of a predicted path #440

Conversation

maxime-clem
Copy link
Contributor

Description

Add parameter for autowarefoundation/autoware.universe#4217

Tests performed

Tested in Psim.

Before (equivalent to a min confidence of 0.0)

The predicted path with 0.08 confidence is detected to collide with ego when it overlaps the right-side lane.
image

After (with a min confidence of 0.1)

The predicted path with 0.08 confidence is ignored and no collisions are detected.
image

Effects on system behavior

Less false positives when using the out_of_lane module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-add_param_min_predicted_path_probability branch from 277b6a9 to dfc1bdc Compare July 12, 2023 01:57
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
…/behavior_planning/behavior_path_planner/scene_module_manager.param.yaml
@maxime-clem maxime-clem merged commit b9f7c0e into autowarefoundation:main Aug 1, 2023
8 of 9 checks passed
@maxime-clem maxime-clem deleted the feat/out_of_lane-add_param_min_predicted_path_probability branch August 1, 2023 13:13
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
… making (#440)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
maxime-clem added a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
…th (autowarefoundation#440)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 28, 2023
…ge-from-private

feat(autoware_launch): add stop_distance_threshold in merge_from_priv…
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Aug 1, 2024
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants