Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(probabilistic_occupancy_grid_map): add projective raytracing option from scan_origin #434

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jul 5, 2023

Description

Modified/Fixed pointcloud based ocucpancy grid_map to consider the projected length of obstacle point clouds from scan_origin to estimate long range unknown region better.

Related links

feature PR: autowarefoundation/autoware.universe#4170

Tests performed

  • Psim works as before
  • logging_simulator works as before

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin changed the title Feat/projective pointcloud occupancy feat(probabilistic_occupancy_grid_map): add projective raytracing option from scan_origin Jul 5, 2023
@soblin soblin marked this pull request as ready for review July 5, 2023 04:41
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/projective-pointcloud-occupancy branch from 762a933 to b3fb7a6 Compare July 6, 2023 08:43
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/projective-pointcloud-occupancy branch from b3fb7a6 to f0c8f04 Compare July 7, 2023 00:53
@soblin soblin requested a review from YoshiRi July 7, 2023 00:53
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit b1a86ca into autowarefoundation:main Jul 7, 2023
8 of 9 checks passed
@soblin soblin deleted the feat/projective-pointcloud-occupancy branch July 18, 2023 02:06
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
soblin added a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
soblin added a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
soblin added a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
takayuki5168 referenced this pull request in tier4/autoware_launch Sep 22, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants