-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(avoidance): parameterize magic number #426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
refactor/remove-magic-number
branch
from
July 6, 2023 00:36
d7d7803
to
cd15236
Compare
5 tasks
kyoichi-sugahara
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jul 23, 2023
kyoichi-sugahara
pushed a commit
that referenced
this pull request
Sep 3, 2023
* add: launcher for pointpainting Signed-off-by: tzhong518 <sworgun@gmail.com> * fix: change perception launch Signed-off-by: tzhong518 <sworgun@gmail.com> Signed-off-by: tzhong518 <sworgun@gmail.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
badai-nguyen
pushed a commit
to badai-nguyen/autoware_launch
that referenced
this pull request
Sep 21, 2023
…arefoundation#426) (autowarefoundation#428) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
badai-nguyen
pushed a commit
to badai-nguyen/autoware_launch
that referenced
this pull request
Mar 6, 2024
…arefoundation#426) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Jun 13, 2024
chore: sync awf-latest
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Sep 3, 2024
…arefoundation#426) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the avoidance module of the behavior path planner to use a new parameter
lateral_avoid_check_threshold
for checking the lateral shift of the ego vehicle during avoidance maneuvers.Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.