Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to control launch xml #199

Closed
wants to merge 1 commit into from
Closed

feat: migrate to control launch xml #199

wants to merge 1 commit into from

Conversation

wep21
Copy link

@wep21 wep21 commented Feb 7, 2023

Description

use control launch xml instead of launch python after this PR has meged.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kenji-miyake kenji-miyake mentioned this pull request Feb 7, 2023
Closed
7 tasks
purewater0901 pushed a commit that referenced this pull request Feb 28, 2023
@h-ohta
fix: typo extra > (#199)
3261e89
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Mar 23, 2023
@tier4-autoware-private-bot @tkimura4
@rej55 @YamatoAndo @dependabot @kenji-miyake @yabuta @tier4-autoware-public-bot @pre-commit-ci @wep21 @zulfaqar-azmi-t4 @taikitanaka3 @h-ohta @yukkysaito @takayuki5168
sync upstream (autowarefoundation#206)
cb7edec 
* update parameter (autowarefoundation#169)

* Port pure pursuit (autowarefoundation#166)

* Fix control.launch.py

* Apply pre-commit

* Fix control.launch.py

* Change debug topic name in rviz setting

* fix typo in localization util.launch.py (autowarefoundation#168)

* Feature/add covarinace param (autowarefoundation#170)

* add covariance param

* add description

* remove unused param (autowarefoundation#172)

* Bump streetsidesoftware/cspell-action from 1.3.4 to v1 (autowarefoundation#174)

* Bump streetsidesoftware/cspell-action from 1.3.4 to 1.5.0

Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 1.3.4 to 1.5.0.
- [Release notes](https://github.com/streetsidesoftware/cspell-action/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md)
- [Commits](streetsidesoftware/cspell-action@v1.3.4...v1.5.0)

---
updated-dependencies:
- dependency-name: streetsidesoftware/cspell-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update spell_check_pr.yml

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix: fix hdd_monitor param (autowarefoundation#173)

* add rosbridge launch (autowarefoundation#175)

* add rosbridge launch

* fix TODO document

add link to pull request

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix double-byte character

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (autowarefoundation#177)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* ci: update CI settings (autowarefoundation#176)

* ci(pre-commit): update .pre-commit-config.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci: add sync-files.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: remove old workflows

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(sync-upstream): update sync-upstream.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

* style: fix for yamllint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: minor update CI settings (autowarefoundation#179)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [pre-commit.ci] pre-commit autoupdate (autowarefoundation#178)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0)
- [github.com/igorshubovych/markdownlint-cli: v0.29.0 → v0.30.0](igorshubovych/markdownlint-cli@v0.29.0...v0.30.0)
- [github.com/pre-commit/mirrors-prettier: v2.4.1 → v2.5.1](pre-commit/mirrors-prettier@v2.4.1...v2.5.1)
- [github.com/pycqa/isort: 5.9.3 → 5.10.1](PyCQA/isort@5.9.3...5.10.1)
- [github.com/psf/black: 21.9b0 → 22.1.0](psf/black@21.9b0...22.1.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: fix CI settings (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: sync files (autowarefoundation#180)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (autowarefoundation#184)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: add paricle param (autowarefoundation#181)

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* chore: sync files (autowarefoundation#185)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (autowarefoundation#186)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync system config (autowarefoundation#187)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* chore: sync files (autowarefoundation#189)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: wep21 <wep21@users.noreply.github.com>

* chore: replace system config in system launch (autowarefoundation#188)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* feat: adds additional configuration flags for behavior_path_planner (autowarefoundation#171)

* feat: adds additional configuration flags for behavior_path_planner

The additional configuration is used to allows avoidance over lane with same and
different direction, as well as allows safety margin between linestring and ego.

This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496
port.

Related PR:
autowarefoundation/autoware.universe#285
autowarefoundation/autoware.universe#287

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Change lateral_collision_margion to 1.0 to reflect changes.

The decision to change the parameter value to 1.0 is made after performing
drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting
between planning control team on 3rd of February 2022.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: slightly increase the safety buffer.

This increases the shift length to 1.7 + 0.5 * vehicle width.

The decision to increase is based on the discussion between planning team and
also the advice from the FI team.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* feat(behavior_velocity): add path marker visualization (autowarefoundation#190)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: sync files (autowarefoundation#193)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (autowarefoundation#194)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* chore: update workflow files name

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>
Co-authored-by: h-ohta <hiroki.ota@tier4.jp>

* chore: sync files (autowarefoundation#195)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>

* feat: lateral controller param (autowarefoundation#191)

* feat: define lat_controller_param_path

* feat: change for trajectory_follower params

* add args for lat_controller_param_path

* chore: fix wrong essential param to optional (autowarefoundation#197)

* fix wrong param line

* move pointcloud_container_name param to optional

* fix: typo extra `>` (autowarefoundation#199)

* Chore arrange perception rviz topics (autowarefoundation#196)

* feat(autoware_launch): add occupancy grid vizualization

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(autoware_launch): add object recognition namespace to rviz

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: delete unused in control_launch (autowarefoundation#200)

* fix: delete unused in control.launch.py

* fix: delete velocity_controller.param.yaml

* feat: add system_monitor parameters in sync-files (autowarefoundation#201)

* chore: sync files (autowarefoundation#202)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>

* chore: sync files (autowarefoundation#203)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: update settings of sync-files (autowarefoundation#204)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat(control_launch): remove unnecessary params (autowarefoundation#206)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* chore: sync files (autowarefoundation#208)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat(atutoware.rviz): disable selectable for pointcloud visualization (autowarefoundation#207)

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* chore: sync files (autowarefoundation#212)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* delete vehicle parameters in longitudinal_controller.param.yaml

* apply pre-commit

* remove unused file

* update sync-param-files.yaml

* disable local_external_control in system_error_montitor_psim

Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: yabuta <makoto.yabuta@tier4.jp>
Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: wep21 <wep21@users.noreply.github.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>
Co-authored-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
@stale
Copy link

stale bot commented Apr 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Apr 8, 2023
@wep21 wep21 closed this Jun 25, 2023
@wep21 wep21 deleted the feature/control-launch-xml branch June 25, 2023 08:24
tkimura4 pushed a commit to tkimura4/autoware_launch that referenced this pull request Sep 8, 2023
@tier4-autoware-public-bot
Merge pull request autowarefoundation#199 from tier4/sync-awf-upstream
59edc16 
chore: sync awf/autoware_launch
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
@mkuri @0x126
feat(system_launch): use mrm comfortable stop (autowarefoundation#199)
626c041 
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@xmfcx xmfcx added status:stale and removed stale labels Jul 5, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
@mkuri @saka1-s
feat(system_launch): use mrm comfortable stop (autowarefoundation#199)
e7b2a28 
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@rej55 rej55 Awaiting requested review from rej55 rej55 will be requested when the pull request is marked ready for review rej55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota will be requested when the pull request is marked ready for review satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk will be requested when the pull request is marked ready for review shmpwk is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran will be requested when the pull request is marked ready for review danielsanchezaran is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara will be requested when the pull request is marked ready for review kyoichi-sugahara is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 will be requested when the pull request is marked ready for review zulfaqar-azmi-t4 is a code owner

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori will be requested when the pull request is marked ready for review go-sakayori is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 will be requested when the pull request is marked ready for review kosuke55 is a code owner

@mkquda mkquda Awaiting requested review from mkquda mkquda will be requested when the pull request is marked ready for review mkquda is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem maxime-clem will be requested when the pull request is marked ready for review maxime-clem is a code owner

@soblin soblin Awaiting requested review from soblin soblin will be requested when the pull request is marked ready for review soblin is a code owner

@yhisaki yhisaki Awaiting requested review from yhisaki yhisaki will be requested when the pull request is marked ready for review yhisaki is a code owner

Assignees
No one assigned
Labels
status:stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wep21 @xmfcx