Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autonomous_emergency_braking): add info marker to aeb and state check override #1103

Conversation

danielsanchezaran
Copy link
Contributor

Description

Needed by autowarefoundation/autoware.universe#8312

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran marked this pull request as ready for review August 1, 2024 06:14
@github-actions github-actions bot added the component:ui User interface, user experience, graphical user interfaces. (auto-assigned) label Aug 1, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you LGTM!
Could you paste the some evidence to show rviz visualization with screenshot?

@danielsanchezaran
Copy link
Contributor Author

danielsanchezaran commented Aug 2, 2024

Thank you LGTM! Could you paste the some evidence to show rviz visualization with screenshot?

Sure!

Here you can see the AEB info marker active (default) as soon as you launch Autoware:

image

Also a vid showing the info topic (stop wall)

cap-.2024-08-02-10-28-24.mp4

@danielsanchezaran danielsanchezaran merged commit 83c6907 into autowarefoundation:main Aug 2, 2024
13 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/awf-add-info-marker-to-aeb branch August 2, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interface, user experience, graphical user interfaces. (auto-assigned) tag:run-build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants