fix(static_obstacle_avoidance): remove redundant calculation

[go-sakayori]

Description

Inside fillAvoidanceTargetObjects function, filterTargetObjects and updateRoadShoulderDistance are called sequentially.
Both function calls getRoadShoulderDistance function, which is relatively time consuming (refer to figure).
The updateRoadShoulderDistance function updates the target object's distance to road shoulder (to_road_shoulder_distance) and avoidance margin (avoid_margin) according to the clip object information.
However, this calculation would be redundant if there is no clip objects.
This PR will resolve the above problem.

Related links

How was this PR tested?

• TIER IV internal evauator

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[satoshi-ota]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (73a9788) to head (027c460).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...ath_static_obstacle_avoidance_module/src/utils.cpp	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8955      +/-   ##
==========================================
- Coverage   28.47%   28.47%   -0.01%     
==========================================
  Files        1314     1315       +1     
  Lines       98279    98298      +19     
  Branches    39985    39988       +3     
==========================================
+ Hits        27985    27989       +4     
- Misses      70207    70222      +15     
  Partials       87       87              

Flag	Coverage Δ		*Carryforward flag
differential	20.89% <50.00%> (?)
total	28.47% <ø> (ø)		Carriedforward from 73a9788

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.