Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(map_loader)!: prefix package and namespace with autoware #8927

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

add autoware prefix

ee42a33
Select commit
Loading
Failed to load commit list.
Open

refactor(map_loader)!: prefix package and namespace with autoware #8927

add autoware prefix
ee42a33
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 27, 2024 in 35s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.06 (9.11 -> 9.05)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method lanelet2_map_visualization_node.cpp: Lanelet2MapVisualizationNode::on_map_bin
  • Excess Number of Function Arguments lanelet2_map_visualization_node.cpp: set_color

Annotations

Check warning on line 315 in map/autoware_lanelet2_map_visualizer/src/lanelet2_map_visualization_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

Lanelet2MapVisualizationNode::on_map_bin has 219 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 66 in map/autoware_lanelet2_map_visualizer/src/lanelet2_map_visualization_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

set_color has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.