Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(map_loader)!: prefix package and namespace with autoware #8927

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Sep 20, 2024

Description

This PR will add the autoware prefix to map_loader package.

Related links

Parent Issue:

How was this PR tested?

Checked with running the autoware sample-map.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@a-maumau
Copy link
Contributor Author

a-maumau commented Sep 20, 2024

This branch is forked from and contains the changes in #8878 .
After #8878 merged, hopefully this will merge smoothly.

@SakodaShintaro
Copy link
Contributor

@a-maumau
There are some conflicts. Could you revolve them?

@a-maumau
Copy link
Contributor Author

@SakodaShintaro I have resolved the conflicts.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed logging_simulator works well.

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Add autoware:: to namespace.
    • Add autoware folder as necessary and update include statements accordingly.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

LGTM

@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 26, 2024
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.50%. Comparing base (ff669fd) to head (ee42a33).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...c/lanelet2_map_loader/lanelet2_local_projector.hpp 0.00% 6 Missing ⚠️
...visualizer/src/lanelet2_map_visualization_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8927      +/-   ##
==========================================
- Coverage   28.51%   28.50%   -0.01%     
==========================================
  Files        1314     1331      +17     
  Lines       98292    98809     +517     
  Branches    40005    40216     +211     
==========================================
+ Hits        28026    28166     +140     
- Misses      70210    70571     +361     
- Partials       56       72      +16     
Flag Coverage Δ *Carryforward flag
differential 9.69% <41.66%> (?)
total 28.51% <ø> (-0.01%) ⬇️ Carriedforward from ff669fd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants